Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

fix: cannot read properties of undefined #124

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix: cannot read properties of undefined #124

merged 2 commits into from
Aug 7, 2024

Conversation

nikoPLP
Copy link

@nikoPLP nikoPLP commented Aug 6, 2024

Hello again,
There is another small bug that gives an error Cannot read properties of undefined (reading 'length').
I contacted the author of CodeMirror thinking that the bug was with the lib style-mod, but in fact, it is just because you are not using the StyleModule API correctly, as he told me.

Here is the fix.
I tested and it works well.
Could you please do another minor release too ? So i could have a nice dependency tree in my project, with the fix coming from npm.
Thank you

@enpitsuLin
Copy link
Owner

Great, thanks for your contribution, I'll take a look

@enpitsuLin enpitsuLin merged commit 44c6ce6 into enpitsuLin:master Aug 7, 2024
@enpitsuLin
Copy link
Owner

as you mentioned before, do you have some problems with how to develop this project? maybe I'll add some contribution guide later

@nikoPLP
Copy link
Author

nikoPLP commented Aug 7, 2024

Sorry the package.json I just pushed is incorrect. there is one , too much. Are you able to build ?

About the issue I have on the build side, I'll open an issue with the output I get so you can tell me what it is

@enpitsuLin enpitsuLin mentioned this pull request Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants